Skip to content

Fix JET analysis (#502) #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 3, 2025
Merged

Fix JET analysis (#502) #503

merged 5 commits into from
Oct 3, 2025

Conversation

devmotion
Copy link
Member

@devmotion devmotion commented Oct 3, 2025 •
edited
Loading

Fixes #502.

Unfortunately, since SpecialFunctions still supports and tests Julia 1.5 but JET has never been compatible with Julia 1.5 (https://github.com/aviatesk/JET.jl/blob/v0.1.0/Project.toml), it's not possible to add regression tests with JET for the example in #502 unless one performs Pkg operations in the tests (which I try to avoid).

Locally, with this PR I get:

julia> using SpecialFunctions, JET

julia> @test_call SpecialFunctions._logabsgamma(1.0)
Test Passed

julia> @test_call SpecialFunctions._logabsgamma(1.0f0)
Test Passed

julia> @test_opt SpecialFunctions._logabsgamma(1.0)
Test Passed

julia> @test_opt SpecialFunctions._logabsgamma(1.0f0)
Test Passed

julia> versioninfo()
Julia Version 1.12.0-rc3
Commit 7522b240144 (2025-09-26 07:42 UTC)
Build Info:
  Official https://julialang.org release
Platform Info:
  OS: macOS (arm64-apple-darwin22.4.0)
  CPU: 10 × Apple M2 Pro
  WORD_SIZE: 64
  LLVM: libLLVM-18.1.7 (ORCJIT, apple-m2)
  GC: Built with stock GC
Threads: 1 default, 1 interactive, 1 GC (on 6 virtual cores)

@codecov
Copy link

codecov bot commented Oct 3, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.93%. Comparing base (fddf5e0) to head (9a75671).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #503      +/-   ##
==========================================
- Coverage   94.04%   93.93%   -0.11%     
==========================================
  Files          14       14              
  Lines        2904     2902       -2     
==========================================
- Hits         2731     2726       -5     
- Misses        173      176       +3
Flag Coverage Δ
unittests 93.93% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@giordano
Copy link
Member

giordano commented Oct 3, 2025

since SpecialFunctions still supports and tests Julia 1.5

I'd say it's a good time to move to v1.10 or something around that.

@devmotion devmotion mentioned this pull request Oct 3, 2025
Merged
giordano
giordano reviewed Oct 3, 2025
View reviewed changes
@devmotion @giordano
Add missing newline character
9a75671 
Co-authored-by: Mosè Giordano <[email protected]>
@devmotion devmotion requested a review from giordano October 3, 2025 20:26
@devmotion devmotion merged commit 1743a8b into master Oct 3, 2025
14 of 15 checks passed
@devmotion devmotion deleted the dw/jet branch October 3, 2025 20:35
@penelopeysm penelopeysm mentioned this pull request Oct 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giordano giordano giordano approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Julia 1.12 / JET v0.10.7 warns that local variable nadj may be undefined

2 participants

@devmotion @giordano